PhpParameterReflection - safe guards against nonexistent classes

ondrejmirtes · ondrejmirtes · commit 51fb445d4d90 · 2020-06-11T15:33:23.000+02:00
diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -145,7 +145,8 @@ private function getParameters(): array
 		return array_map(function (\ReflectionParameter $reflection): PhpParameterReflection {
 			return new PhpParameterReflection(
 				$reflection,
-				$this->phpDocParameterTypes[$reflection->getName()] ?? null
+				$this->phpDocParameterTypes[$reflection->getName()] ?? null,
+				null
 			);
 		}, $this->reflection->getParameters());
 	}
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -244,7 +244,8 @@ private function getParameters(): array
 			$this->parameters = array_map(function (\ReflectionParameter $reflection): PhpParameterReflection {
 				return new PhpParameterReflection(
 					$reflection,
-					$this->phpDocParameterTypes[$reflection->getName()] ?? null
+					$this->phpDocParameterTypes[$reflection->getName()] ?? null,
+					$this->getDeclaringClass()->getName()
 				);
 			}, $this->reflection->getParameters());
 		}
diff --git a/src/Reflection/Php/PhpParameterReflection.php b/src/Reflection/Php/PhpParameterReflection.php
@@ -20,10 +20,17 @@ class PhpParameterReflection implements ParameterReflectionWithPhpDocs
 
 	private ?\PHPStan\Type\Type $nativeType = null;
 
-	public function __construct(\ReflectionParameter $reflection, ?Type $phpDocType)
+	private ?string $declaringClassName;
+
+	public function __construct(
+		\ReflectionParameter $reflection,
+		?Type $phpDocType,
+		?string $declaringClassName
+	)
 	{
 		$this->reflection = $reflection;
 		$this->phpDocType = $phpDocType;
+		$this->declaringClassName = $declaringClassName;
 	}
 
 	public function isOptional(): bool
@@ -47,7 +54,7 @@ public function getType(): Type
 			$this->type = TypehintHelper::decideTypeFromReflection(
 				$this->reflection->getType(),
 				$phpDocType,
-				null,
+				$this->declaringClassName,
 				$this->isVariadic()
 			);
 		}
@@ -82,7 +89,7 @@ public function getNativeType(): Type
 			$this->nativeType = TypehintHelper::decideTypeFromReflection(
 				$this->reflection->getType(),
 				null,
-				$this->reflection->getDeclaringClass() !== null ? $this->reflection->getDeclaringClass()->getName() : null,
+				$this->declaringClassName,
 				$this->isVariadic()
 			);
 		}
@@ -93,7 +100,13 @@ public function getNativeType(): Type
 	public function getDefaultValue(): ?Type
 	{
 		if ($this->reflection->isDefaultValueAvailable()) {
-			return ConstantTypeHelper::getTypeFromValue($this->reflection->getDefaultValue());
+			try {
+				$defaultValue = $this->reflection->getDefaultValue();
+			} catch (\Throwable $e) {
+				return null;
+			}
+
+			return ConstantTypeHelper::getTypeFromValue($defaultValue);
 		}
 
 		return null;
diff --git a/src/Testing/RuleTestCase.php b/src/Testing/RuleTestCase.php
@@ -156,7 +156,7 @@ static function (array $error) use ($strictlyTypedSprintf): string {
 			static function (Error $error) use ($strictlyTypedSprintf): string {
 				$line = $error->getLine();
 				if ($line === null) {
-					throw new \PHPStan\ShouldNotHappenException(sprintf('Error (%s) line should not be null.', $error->getMessage()));
+					return $strictlyTypedSprintf(-1, $error->getMessage(), $error->getTip());
 				}
 				return $strictlyTypedSprintf($line, $error->getMessage(), $error->getTip());
 			},
diff --git a/tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php
@@ -1411,4 +1411,17 @@ public function testBug3415Two(): void
 		$this->analyse([__DIR__ . '/data/bug-3415-2.php'], []);
 	}
 
+	public function testBug3445(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-3445.php'], [
+			[
+				'Parameter #1 $test of method Bug3445\Foo::doFoo() expects Bug3445\Foo, $this(Bug3445\Bar) given.',
+				26,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-3445.php b/tests/PHPStan/Rules/Methods/data/bug-3445.php
@@ -0,0 +1,31 @@
+<?php
+
+namespace Bug3445;
+
+class Foo
+{
+
+	public function doFoo(self $test): void
+	{
+
+	}
+
+	public function doBar($test = UnknownClass::BAR): void
+	{
+
+	}
+
+}
+
+class Bar
+{
+
+	public function doFoo(Foo $foo)
+	{
+		$foo->doFoo(new Foo());
+		$foo->doFoo($this);
+
+		$foo->doBar(new \stdClass());
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ static function (array $error) use ($strictlyTypedSprintf): string {`
`156`	`156`	`static function (Error $error) use ($strictlyTypedSprintf): string {`
`157`	`157`	`$line = $error->getLine();`
`158`	`158`	`if ($line === null) {`
`159`		`- throw new \PHPStan\ShouldNotHappenException(sprintf('Error (%s) line should not be null.', $error->getMessage()));`
	`159`	`+ return $strictlyTypedSprintf(-1, $error->getMessage(), $error->getTip());`
`160`	`160`	`}`
`161`	`161`	`return $strictlyTypedSprintf($line, $error->getMessage(), $error->getTip());`
`162`	`162`	`},`