SprintfFunctionDynamicReturnTypeExtension - limit combinatorial explosion

ondrejmirtes · ondrejmirtes · commit 51cffd49dcf0 · 2024-02-05T10:07:52.000+01:00
diff --git a/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php b/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php
@@ -85,13 +85,20 @@ public function getTypeFromFunctionCall(
 		}
 
 		$values = [];
+		$combinationsCount = 1;
 		foreach ($args as $arg) {
 			$argType = $scope->getType($arg->value);
 			if (count($argType->getConstantScalarValues()) === 0) {
 				return $returnType;
 			}
 
-			$values[] = $argType->getConstantScalarValues();
+			$constantScalarValues = $argType->getConstantScalarValues();
+			$values[] = $constantScalarValues;
+			$combinationsCount *= count($constantScalarValues);
+		}
+
+		if ($combinationsCount > InitializerExprTypeResolver::CALCULATE_SCALARS_LIMIT) {
+			return $returnType;
 		}
 
 		$combinations = CombinationsHelper::combinations($values);
diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -1294,6 +1294,12 @@ public function testBug10509(): void
 		$this->assertSame('PHPDoc tag @return contains unresolvable type.', $errors[1]->getMessage());
 	}
 
+	public function testBug10538(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-10538.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]
diff --git a/tests/PHPStan/Analyser/data/bug-10538.php b/tests/PHPStan/Analyser/data/bug-10538.php

Original file line number	Diff line number	Diff line change
`@@ -85,13 +85,20 @@ public function getTypeFromFunctionCall(`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`$values = [];`
	`88`	`+ $combinationsCount = 1;`
`88`	`89`	`foreach ($args as $arg) {`
`89`	`90`	`$argType = $scope->getType($arg->value);`
`90`	`91`	`if (count($argType->getConstantScalarValues()) === 0) {`
`91`	`92`	`return $returnType;`
`92`	`93`	`}`
`93`	`94`
`94`		`- $values[] = $argType->getConstantScalarValues();`
	`95`	`+ $constantScalarValues = $argType->getConstantScalarValues();`
	`96`	`+ $values[] = $constantScalarValues;`
	`97`	`+ $combinationsCount *= count($constantScalarValues);`
	`98`	`+ }`
	`99`	`+`
	`100`	`+ if ($combinationsCount > InitializerExprTypeResolver::CALCULATE_SCALARS_LIMIT) {`
	`101`	`+ return $returnType;`
`95`	`102`	`}`
`96`	`103`
`97`	`104`	`$combinations = CombinationsHelper::combinations($values);`