Parameters schema - structured featureToggles to disallow unsupported keys

ondrejmirtes · ondrejmirtes · commit 4f51382d4d8a · 2020-02-25T19:44:59.000+01:00
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -1,8 +1,6 @@
 parameters:
 	customRulesetUsed: false
 	missingClosureNativeReturnCheckObjectTypehint: false
-	featureToggles:
-		closureUsesThis: false
 
 conditionalTags:
 	PHPStan\Rules\Functions\ClosureUsesThisRule:
diff --git a/conf/config.level5.neon b/conf/config.level5.neon
@@ -8,8 +8,7 @@ conditionalTags:
 parameters:
 	checkFunctionArgumentTypes: true
 	checkArgumentsPassedByReference: true
-	featureToggles:
-		randomIntParameters: false
+
 
 services:
 	-
diff --git a/conf/config.neon b/conf/config.neon
@@ -11,6 +11,8 @@ parameters:
 		disableRuntimeReflectionProvider: false
 		enableScanningPaths: false
 		resultCache: false
+		closureUsesThis: false
+		randomIntParameters: false
 	fileExtensions:
 		- php
 	checkAlwaysTrueCheckTypeFunctionCall: false
@@ -125,7 +127,15 @@ parametersSchema:
 	autoload_files: listOf(string())
 	level: schema(anyOf(int(), string()), nullable())
 	paths: listOf(string())
-	featureToggles: arrayOf(bool())
+	featureToggles: structure([
+		disableRobotLoader: bool(),
+		staticReflectionForPhpParser: bool(),
+		disableRuntimeReflectionProvider: bool(),
+		enableScanningPaths: bool(),
+		resultCache: bool(),
+		closureUsesThis: bool(),
+		randomIntParameters: bool()
+	])
 	fileExtensions: listOf(string())
 	checkAlwaysTrueCheckTypeFunctionCall: bool()
 	checkAlwaysTrueInstanceof: bool()

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,7 @@ conditionalTags:`
`8`	`8`	`parameters:`
`9`	`9`	`checkFunctionArgumentTypes: true`
`10`	`10`	`checkArgumentsPassedByReference: true`
`11`		`- featureToggles:`
`12`		`- randomIntParameters: false`
	`11`	`+`
`13`	`12`
`14`	`13`	`services:`
`15`	`14`	`-`