Check abstract method in non-abstract class

ondrejmirtes · ondrejmirtes · commit 487f2fa1bb1d · 2020-06-05T22:43:52.000+02:00
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -28,6 +28,7 @@ rules:
 	- PHPStan\Rules\Functions\ExistingClassesInTypehintsRule
 	- PHPStan\Rules\Functions\InnerFunctionRule
 	- PHPStan\Rules\Functions\PrintfParametersRule
+	- PHPStan\Rules\Methods\AbstractMethodInNonAbstractClassRule
 	- PHPStan\Rules\Methods\ExistingClassesInTypehintsRule
 	- PHPStan\Rules\Methods\OverridingMethodRule
 	- PHPStan\Rules\Properties\AccessPropertiesInAssignRule
diff --git a/src/Rules/Methods/AbstractMethodInNonAbstractClassRule.php b/src/Rules/Methods/AbstractMethodInNonAbstractClassRule.php
@@ -0,0 +1,41 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Methods;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+
+/**
+ * @implements Rule<Node\Stmt\ClassMethod>
+ */
+class AbstractMethodInNonAbstractClassRule implements Rule
+{
+
+	public function getNodeType(): string
+	{
+		return Node\Stmt\ClassMethod::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		if (!$scope->isInClass()) {
+			throw new \PHPStan\ShouldNotHappenException();
+		}
+
+		$class = $scope->getClassReflection();
+		if ($class->isAbstract()) {
+			return [];
+		}
+
+		if (!$node->isAbstract()) {
+			return [];
+		}
+
+		return [
+			RuleErrorBuilder::message(sprintf('Non-abstract class %s contains abstract method %s().', $class->getName(), $node->name->toString()))->nonIgnorable()->build(),
+		];
+	}
+
+}
diff --git a/tests/PHPStan/Rules/Methods/AbstractMethodInNonAbstractClassRuleTest.php b/tests/PHPStan/Rules/Methods/AbstractMethodInNonAbstractClassRuleTest.php
@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Methods;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<AbstractMethodInNonAbstractClassRule>
+ */
+class AbstractMethodInNonAbstractClassRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new AbstractMethodInNonAbstractClassRule();
+	}
+
+	public function testRule(): void
+	{
+		if (!self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires static reflection.');
+		}
+		$this->analyse([__DIR__ . '/data/abstract-method.php'], [
+			[
+				'Non-abstract class AbstractMethod\Bar contains abstract method doBar().',
+				15,
+			],
+			[
+				'Non-abstract class AbstractMethod\Baz contains abstract method doBar().',
+				22,
+			],
+		]);
+	}
+
+}
diff --git a/tests/PHPStan/Rules/Methods/data/abstract-method.php b/tests/PHPStan/Rules/Methods/data/abstract-method.php
@@ -0,0 +1,40 @@
+<?php
+
+namespace AbstractMethod;
+
+abstract class Foo
+{
+
+	abstract public function doFoo(): void;
+
+}
+
+class Bar
+{
+
+	abstract public function doBar(): void;
+
+}
+
+interface Baz
+{
+
+	abstract public function doBar(): void;
+
+}
+
+trait X
+{
+
+	abstract public static function a(self $b): void;
+
+}
+
+class Y
+{
+
+	use X;
+
+	public static function a(self $b): void {}
+
+}
