Fixed skipping shadowed trait method by a native method

ondrejmirtes · ondrejmirtes · commit 2de6a241caf3 · 2021-01-12T15:15:44.000+01:00
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -78,6 +78,7 @@
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\Native\NativeMethodReflection;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Reflection\PassedByReference;
@@ -360,6 +361,9 @@ private function processStmtNode(
 				&& $scope->getClassReflection()->hasNativeMethod($stmt->name->toString())
 			) {
 				$methodReflection = $scope->getClassReflection()->getNativeMethod($stmt->name->toString());
+				if ($methodReflection instanceof NativeMethodReflection) {
+					return new StatementResult($scope, false, false, []);
+				}
 				if ($methodReflection instanceof PhpMethodReflection) {
 					$declaringTrait = $methodReflection->getDeclaringTrait();
 					if ($declaringTrait === null || $declaringTrait->getName() !== $scope->getTraitReflection()->getName()) {
diff --git a/tests/PHPStan/Rules/Methods/AbstractMethodInNonAbstractClassRuleTest.php b/tests/PHPStan/Rules/Methods/AbstractMethodInNonAbstractClassRuleTest.php
@@ -59,4 +59,9 @@ public function testbug3406AnotherCase(): void
 		$this->analyse([__DIR__ . '/data/bug-3406_2.php'], []);
 	}
 
+	public function testBug4214(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-4214.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-4214.php b/tests/PHPStan/Rules/Methods/data/bug-4214.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace Bug4214;
+
+trait AbstractTrait {
+	abstract public function getMessage();
+}
+
+class Test extends \Exception {
+	use AbstractTrait;
+}

Original file line number	Diff line number	Diff line change
`@@ -59,4 +59,9 @@ public function testbug3406AnotherCase(): void`
`59`	`59`	`$this->analyse([__DIR__ . '/data/bug-3406_2.php'], []);`
`60`	`60`	`}`
`61`	`61`
	`62`	`+ public function testBug4214(): void`
	`63`	`+ {`
	`64`	`+ $this->analyse([__DIR__ . '/data/bug-4214.php'], []);`
	`65`	`+ }`
	`66`	`+`
`62`	`67`	`}`