Mitigation of some problems

ondrejmirtes · ondrejmirtes · commit 2d8dcd1722b5 · 2020-09-26T19:55:59.000+02:00
diff --git a/src/Command/FixerApplication.php b/src/Command/FixerApplication.php
@@ -359,8 +359,9 @@ private function downloadPhar(
 
 		$output->writeln('<fg=green>Downloading the latest PHPStan Pro...</>');
 
+		$pharPathResource = fopen($pharPath, 'w');
 		$progressBar = new ProgressBar($output);
-		$client->requestStreaming('GET', $latestInfo['url'])->then(static function (ResponseInterface $response) use ($loop, $pharPath, $progressBar): void {
+		$client->requestStreaming('GET', $latestInfo['url'])->done(static function (ResponseInterface $response) use ($loop, $pharPath, $progressBar, $pharPathResource): void {
 			$body = $response->getBody();
 			if (!$body instanceof \React\Stream\ReadableStreamInterface) {
 				throw new \PHPStan\ShouldNotHappenException();
@@ -371,7 +372,7 @@ private function downloadPhar(
 			$progressBar->setMessage(sprintf('%.2f MB', $totalSize / 1000000), 'fileSize');
 			$progressBar->start($totalSize);
 
-			$destination = new \React\Stream\WritableResourceStream(fopen($pharPath, 'w'), $loop);
+			$destination = new \React\Stream\WritableResourceStream($pharPathResource, $loop);
 			$body->pipe($destination);
 
 			$bytes = 0;
@@ -383,6 +384,8 @@ private function downloadPhar(
 
 		$loop->run();
 
+		fclose($pharPathResource);
+
 		$progressBar->finish();
 		$output->writeln('');
 		$output->writeln('');
