constant arrays without an explicit class string should not resolve the class name

rainbow-alex · ondrejmirtes · commit 28ed92404db4 · 2020-06-10T08:44:27.000+02:00
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -352,7 +352,7 @@ private function findTypeAndMethodName(): ?ConstantArrayTypeAndMethod
 			return ConstantArrayTypeAndMethod::createUnknown();
 		}
 
-		if ($classOrObject instanceof ConstantStringType) {
+		if ($classOrObject instanceof ConstantStringType && $classOrObject->isClassString()) {
 			$broker = Broker::getInstance();
 			if (!$broker->hasClass($classOrObject->getValue())) {
 				return ConstantArrayTypeAndMethod::createUnknown();
diff --git a/src/Type/Constant/ConstantStringType.php b/src/Type/Constant/ConstantStringType.php
@@ -45,6 +45,11 @@ public function getValue(): string
 		return $this->value;
 	}
 
+	public function isClassString(): bool
+	{
+		return $this->isClassString;
+	}
+
 	public function describe(VerbosityLevel $level): string
 	{
 		return $level->handle(
diff --git a/tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php b/tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php
@@ -589,4 +589,81 @@ public function testResolveTemplateTypes(Type $received, Type $template, array $
 		);
 	}
 
+	/**
+	 * @dataProvider dataIsCallable
+	 * @group solo
+	 */
+	public function testIsCallable(ConstantArrayType $type, TrinaryLogic $expectedResult): void
+	{
+		$actualResult = $type->isCallable();
+		$this->assertSame(
+			$expectedResult->describe(),
+			$actualResult->describe(),
+			sprintf('%s -> isCallable()', $type->describe(VerbosityLevel::precise()))
+		);
+	}
+
+	public function dataIsCallable(): iterable
+	{
+		yield 'zero items' => [
+			new ConstantArrayType([], []),
+			TrinaryLogic::createNo(),
+		];
+
+		yield 'function name' => [
+			new ConstantArrayType([
+				new ConstantIntegerType(0),
+			], [
+				new ConstantStringType('strlen'),
+			]),
+			TrinaryLogic::createNo(),
+		];
+
+		yield 'existing static method' => [
+			new ConstantArrayType([
+				new ConstantIntegerType(0),
+				new ConstantIntegerType(1),
+			], [
+				new ConstantStringType(\Closure::class, true),
+				new ConstantStringType('bind'),
+			]),
+			TrinaryLogic::createYes(),
+		];
+
+		yield 'non-existing static method' => [
+			new ConstantArrayType([
+				new ConstantIntegerType(0),
+				new ConstantIntegerType(1),
+			], [
+				new ConstantStringType(\Closure::class, true),
+				new ConstantStringType('foobar'),
+			]),
+			TrinaryLogic::createNo(),
+		];
+
+		/**
+		 * @see https://github.com/phpstan/phpstan/issues/3428
+		 */
+		yield 'existing static method but not a class string' => [
+			new ConstantArrayType([
+				new ConstantIntegerType(0),
+				new ConstantIntegerType(1),
+			], [
+				new ConstantStringType('Closure'),
+				new ConstantStringType('foobar'),
+			]),
+			TrinaryLogic::createMaybe(),
+		];
+
+		yield 'existing static method but with string keys' => [
+			new ConstantArrayType([
+				new ConstantStringType('a'),
+				new ConstantStringType('b'),
+			], [
+				new ConstantStringType(\Closure::class, true),
+				new ConstantStringType('bind'),
+			]),
+			TrinaryLogic::createNo(),
+		];
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ private function findTypeAndMethodName(): ?ConstantArrayTypeAndMethod`
`352`	`352`	`return ConstantArrayTypeAndMethod::createUnknown();`
`353`	`353`	`}`
`354`	`354`
`355`		`- if ($classOrObject instanceof ConstantStringType) {`
	`355`	`+ if ($classOrObject instanceof ConstantStringType && $classOrObject->isClassString()) {`
`356`	`356`	`$broker = Broker::getInstance();`
`357`	`357`	`if (!$broker->hasClass($classOrObject->getValue())) {`
`358`	`358`	`return ConstantArrayTypeAndMethod::createUnknown();`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,11 @@ public function getValue(): string`
`45`	`45`	`return $this->value;`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ public function isClassString(): bool`
	`49`	`+ {`
	`50`	`+ return $this->isClassString;`
	`51`	`+ }`
	`52`	`+`
`48`	`53`	`public function describe(VerbosityLevel $level): string`
`49`	`54`	`{`
`50`	`55`	`return $level->handle(`