ArrayType::setOffsetValueType() - generalize key type if it goes over a threshold

ondrejmirtes · ondrejmirtes · commit 24aee609ebf9 · 2022-08-11T13:33:06.000+02:00
diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -25,6 +25,7 @@
 use PHPStan\Type\Traits\UndecidedBooleanTypeTrait;
 use PHPStan\Type\Traits\UndecidedComparisonTypeTrait;
 use function array_merge;
+use function count;
 use function is_float;
 use function is_int;
 use function key;
@@ -279,8 +280,13 @@ public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $uni
 			return $builder->getArray();
 		}
 
+		$keyType = TypeCombinator::union($this->keyType, $offsetType);
+		if (count(TypeUtils::getConstantScalars($keyType)) > ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT) {
+			$keyType = $keyType->generalize(GeneralizePrecision::moreSpecific());
+		}
+
 		$array = new self(
-			TypeCombinator::union($this->keyType, $offsetType),
+			$keyType,
 			$unionValues ? TypeCombinator::union($this->itemType, $valueType) : $valueType,
 		);
 		if ($offsetType instanceof ConstantIntegerType || $offsetType instanceof ConstantStringType) {
