Fix trim issue

VincentLanglet · VincentLanglet · commit 22f0cab4b286 · 2024-11-18T23:12:31.000+01:00
diff --git a/conf/config.neon b/conf/config.neon
@@ -1774,6 +1774,11 @@ services:
 		tags:
 			- phpstan.broker.dynamicFunctionReturnTypeExtension
 
+	-
+		class: PHPStan\Type\Php\TrimFunctionDynamicReturnTypeExtension
+		tags:
+			- phpstan.broker.dynamicFunctionReturnTypeExtension
+
 	-
 		class: PHPStan\Type\Php\VersionCompareFunctionDynamicReturnTypeExtension
 		tags:
diff --git a/src/Type/Php/TrimFunctionDynamicReturnTypeExtension.php b/src/Type/Php/TrimFunctionDynamicReturnTypeExtension.php
@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\FuncCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Type\Accessory\AccessoryLowercaseStringType;
+use PHPStan\Type\Accessory\AccessoryUppercaseStringType;
+use PHPStan\Type\DynamicFunctionReturnTypeExtension;
+use PHPStan\Type\IntersectionType;
+use PHPStan\Type\StringType;
+use PHPStan\Type\Type;
+use function count;
+
+final class TrimFunctionDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension
+{
+
+	public function isFunctionSupported(FunctionReflection $functionReflection): bool
+	{
+		return \in_array($functionReflection->getName(), ['trim', 'rtrim', 'ltrim'], true);
+	}
+
+	public function getTypeFromFunctionCall(
+		FunctionReflection $functionReflection,
+		FuncCall $functionCall,
+		Scope $scope,
+	): ?Type
+	{
+		$args = $functionCall->getArgs();
+		if (count($args) < 1) {
+			return null;
+		}
+
+		$stringType = $scope->getType($args[0]->value);
+		$accessory = [];
+		if ($stringType->isLowercaseString()->yes()) {
+		    $accessory[] = new AccessoryLowercaseStringType();
+		}
+		if ($stringType->isUppercaseString()->yes()) {
+		    $accessory[] = new AccessoryUppercaseStringType();
+		}
+		if (count($accessory) > 0) {
+		    return new IntersectionType([new StringType(), ...$accessory]);
+		}
+
+		return new StringType();
+	}
+
+}
diff --git a/stubs/core.stub b/stubs/core.stub
@@ -322,18 +322,3 @@ function is_callable(mixed $value, bool $syntax_only = false, ?string &$callable
  * @return ($num is float ? float : $num is int ? non-negative-int : float|non-negative-int)
  */
 function abs($num) {}
-
-/**
- * @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
- */
-function trim(string $string, string $characters = " \n\r\t\v\x00"): string {}
-
-/**
- * @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
- */
-function ltrim(string $string, string $characters = " \n\r\t\v\x00"): string {}
-
-/**
- * @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
- */
-function rtrim(string $string, string $characters = " \n\r\t\v\x00"): string {}
