Get native type from reflection

ondrejmirtes · ondrejmirtes · commit 1eedc107ad35 · 2020-06-07T10:01:02.000+02:00
diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -414,6 +414,15 @@ private function createMethod(
 
 			$stubPhpDocString = null;
 			$variants = [];
+			$reflectionMethod = null;
+			if (class_exists($classReflection->getName(), false)) {
+				$reflectionClass = new \ReflectionClass($classReflection->getName());
+				if ($reflectionClass->hasMethod($methodReflection->getName())) {
+					$reflectionMethod = $reflectionClass->getMethod($methodReflection->getName());
+				}
+			} else {
+				$reflectionMethod = $classReflection->getNativeReflection()->getMethod($methodReflection->getName());
+			}
 			foreach ($variantNames as $innerVariantName) {
 				$methodSignature = $this->signatureMapProvider->getFunctionSignature($innerVariantName, $declaringClassName);
 				$phpDocReturnType = null;
@@ -445,7 +454,7 @@ private function createMethod(
 						}
 					}
 				}
-				$variants[] = $this->createNativeMethodVariant($methodSignature, $stubPhpDocParameterTypes, $stubPhpDocParameterVariadicity, $phpDocReturnType);
+				$variants[] = $this->createNativeMethodVariant($methodSignature, $stubPhpDocParameterTypes, $stubPhpDocParameterVariadicity, $phpDocReturnType, $reflectionMethod);
 			}
 
 			if ($this->signatureMapProvider->hasFunctionMetadata($signatureMapMethodName)) {
@@ -552,23 +561,49 @@ private function createMethod(
 	 * @param array<string, Type> $stubPhpDocParameterTypes
 	 * @param array<string, bool> $stubPhpDocParameterVariadicity
 	 * @param Type|null $phpDocReturnType
+	 * @param \ReflectionMethod|null $reflectionMethod
 	 * @return FunctionVariantWithPhpDocs
 	 */
 	private function createNativeMethodVariant(
 		FunctionSignature $methodSignature,
 		array $stubPhpDocParameterTypes,
 		array $stubPhpDocParameterVariadicity,
-		?Type $phpDocReturnType
+		?Type $phpDocReturnType,
+		?\ReflectionMethod $reflectionMethod
 	): FunctionVariantWithPhpDocs
 	{
 		$parameters = [];
-		foreach ($methodSignature->getParameters() as $parameterSignature) {
+		$nativeParameters = null;
+		$nativeReturnType = null;
+		if ($reflectionMethod !== null) {
+			$nativeParameters = $reflectionMethod->getParameters();
+			$nativeReturnType = TypehintHelper::decideTypeFromReflection(
+				$reflectionMethod->getReturnType(),
+				null,
+				null,
+				false
+			);
+		}
+		foreach ($methodSignature->getParameters() as $i => $parameterSignature) {
+			if (
+				$nativeParameters !== null
+				&& array_key_exists($i, $nativeParameters)
+			) {
+				$nativeParameterType = TypehintHelper::decideTypeFromReflection(
+					$nativeParameters[$i]->getType(),
+					null,
+					null,
+					$nativeParameters[$i]->isVariadic()
+				);
+			} else {
+				$nativeParameterType = new MixedType();
+			}
 			$parameters[] = new NativeParameterWithPhpDocsReflection(
 				$parameterSignature->getName(),
 				$parameterSignature->isOptional(),
 				$stubPhpDocParameterTypes[$parameterSignature->getName()] ?? $parameterSignature->getType(),
 				$stubPhpDocParameterTypes[$parameterSignature->getName()] ?? new MixedType(),
-				new MixedType(true), // todo
+				$nativeParameterType,
 				$parameterSignature->passedByReference(),
 				$stubPhpDocParameterVariadicity[$parameterSignature->getName()] ?? $parameterSignature->isVariadic(),
 				null,
@@ -583,7 +618,7 @@ private function createNativeMethodVariant(
 			$methodSignature->isVariadic(),
 			$phpDocReturnType ?? $methodSignature->getReturnType(),
 			$phpDocReturnType ?? new MixedType(),
-			new MixedType(true) // todo $methodSignature->getNativeReturnType()
+			$nativeReturnType ?? new MixedType()
 		);
 	}
 
diff --git a/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php b/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php
@@ -278,4 +278,23 @@ public function testReturnTypeCovariance(
 		$this->analyse([__DIR__ . '/data/return-type-covariance.php'], $expectedErrors);
 	}
 
+	public function testParle(): void
+	{
+		if (!self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires static reflection.');
+		}
+
+		$this->phpVersionId = PHP_VERSION_ID;
+		$this->analyse([__DIR__ . '/data/parle.php'], [
+			[
+				'Parameter #1 $state (int) of method OverridingParle\Foo::pushState() is not contravariant with parameter #1 $state (string) of method Parle\RLexer::pushState().',
+				8,
+			],
+			[
+				'Return type string of method OverridingParle\Foo::pushState() is not covariant with return type int of method Parle\RLexer::pushState().',
+				8,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/parle.php b/tests/PHPStan/Rules/Methods/data/parle.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace OverridingParle;
+
+class Foo extends \Parle\RLexer
+{
+
+	public function pushState(int $state): string
+	{
+
+	}
+
+}
