Assume offset value set was successful for further analysis

ondrejmirtes · ondrejmirtes · commit 1537424191a4 · 2022-08-04T22:56:10.000+02:00
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -5,6 +5,11 @@ parameters:
 			count: 1
 			path: src/Analyser/DirectScopeFactory.php
 
+		-
+			message: "#^Cannot assign offset 'realCount' to array\\|string\\.$#"
+			count: 1
+			path: src/Analyser/IgnoredErrorHelperResult.php
+
 		-
 			message: "#^Function is_a\\(\\) is a runtime reflection concept that might not work in PHPStan because it uses fully static reflection engine\\. Use objects retrieved from ReflectionProvider instead\\.$#"
 			count: 1
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -3523,6 +3523,7 @@ private function specifyExpressionType(Expr $expr, Type $type, ?Type $nativeType
 					$types = [
 						new ArrayType(new MixedType(), new MixedType()),
 						new ObjectType(ArrayAccess::class),
+						new NullType(),
 					];
 					if ($dimType instanceof ConstantIntegerType) {
 						$types[] = new StringType();
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -3374,6 +3374,17 @@ private function processAssignVar(
 			foreach (array_reverse($offsetTypes) as $i => $offsetType) {
 				/** @var Type $offsetValueType */
 				$offsetValueType = array_pop($offsetValueTypeStack);
+				if (!$offsetValueType instanceof MixedType) {
+					$types = [
+						new ArrayType(new MixedType(), new MixedType()),
+						new ObjectType(ArrayAccess::class),
+						new NullType(),
+					];
+					if ($offsetType !== null && (new IntegerType())->isSuperTypeOf($offsetType)->yes()) {
+						$types[] = new StringType();
+					}
+					$offsetValueType = TypeCombinator::intersect($offsetValueType, TypeCombinator::union(...$types));
+				}
 				$valueToWrite = $offsetValueType->setOffsetValueType($offsetType, $valueToWrite, $i === 0);
 			}
 
diff --git a/src/Type/NeverType.php b/src/Type/NeverType.php
@@ -172,7 +172,7 @@ public function getOffsetValueType(Type $offsetType): Type
 
 	public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $unionValues = true): Type
 	{
-		return new NeverType();
+		return new ErrorType();
 	}
 
 	public function unsetOffset(Type $offsetType): Type
diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -167,6 +167,10 @@ public function testRule(): void
 				'Offset \'feature_pretty…\' does not exist on array{version: non-empty-string, commit: string|null, pretty_version: string|null, feature_version: non-empty-string, feature_pretty_version?: string|null}.',
 				504,
 			],
+			[
+				"Cannot access offset 'foo' on bool.",
+				517,
+			],
 		]);
 	}
 
@@ -248,7 +252,7 @@ public function testBug3782(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-3782.php'], [
 			[
-				'Cannot access offset (int|string) on Bug3782\HelloWorld.',
+				'Cannot access offset (int|string) on $this(Bug3782\HelloWorld)|(ArrayAccess&Bug3782\HelloWorld).',
 				11,
 			],
 		]);
diff --git a/tests/PHPStan/Rules/Arrays/data/nonexistent-offset.php b/tests/PHPStan/Rules/Arrays/data/nonexistent-offset.php
@@ -508,3 +508,13 @@ private function postprocess(array $versionData): array
 		return $versionData;
 	}
 }
+
+class OnBool
+{
+
+	public function doFoo(bool $b)
+	{
+		$b['foo'] = 1;
+	}
+
+}
diff --git a/tests/PHPStan/Rules/Comparison/data/bug-4708.php b/tests/PHPStan/Rules/Comparison/data/bug-4708.php
@@ -53,7 +53,7 @@ function GetASCConfig()
 		{
 			assertType('array<string>|true', $result);
 			$result['bsw'] = 1;
-			assertType('*ERROR*', $result); // should be non-empty-array<string|1>&hasOffsetValue('bsw', 1)
+			assertType("non-empty-array<1|string>&hasOffsetValue('bsw', 1)", $result);
 		}
 		else
 		{
@@ -62,7 +62,7 @@ function GetASCConfig()
 			assertType('*NEVER*', $result); // should be non-empty-array<string|int>&hasOffsetValue('bsw', int)
 		}
 
-		assertType('*ERROR*', $result); // should have a better result
+		assertType("non-empty-array<1|string>&hasOffsetValue('bsw', 1)", $result); // should have an int
 
 		if (!isset($result['bew']))
 		{
@@ -73,7 +73,7 @@ function GetASCConfig()
 			$result['bew'] = (int) $result['bew'];
 		}
 
-		assertType('array{bew: int}', $result); // missing bsw key
+		assertType("non-empty-array<int|string>&hasOffsetValue('bsw', 1)", $result); // missing bsw key
 
 		foreach (['utc', 'ssi'] as $field)
 		{
@@ -84,7 +84,7 @@ function GetASCConfig()
 		}
 	}
 
-	assertType("non-empty-array<'bew'|'dberror'|'result'|'ssi'|'utc', 'xyz'|int|false>", $result); // should be non-empty-array<int|string|false>
+	assertType("non-empty-array<int|string|false>", $result);
 
 	return $result;
 }

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ public function getOffsetValueType(Type $offsetType): Type`
`172`	`172`
`173`	`173`	`public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $unionValues = true): Type`
`174`	`174`	`{`
`175`		`- return new NeverType();`
	`175`	`+ return new ErrorType();`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`public function unsetOffset(Type $offsetType): Type`
Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,10 @@ public function testRule(): void`
`167`	`167`	`'Offset \'feature_pretty…\' does not exist on array{version: non-empty-string, commit: string\|null, pretty_version: string\|null, feature_version: non-empty-string, feature_pretty_version?: string\|null}.',`
`168`	`168`	`504,`
`169`	`169`	`],`
	`170`	`+ [`
	`171`	`+ "Cannot access offset 'foo' on bool.",`
	`172`	`+ 517,`
	`173`	`+ ],`
`170`	`174`	`]);`
`171`	`175`	`}`
`172`	`176`
`@@ -248,7 +252,7 @@ public function testBug3782(): void`
`248`	`252`	`{`
`249`	`253`	`$this->analyse([__DIR__ . '/data/bug-3782.php'], [`
`250`	`254`	`[`
`251`		`- 'Cannot access offset (int\|string) on Bug3782\HelloWorld.',`
	`255`	`+ 'Cannot access offset (int\|string) on $this(Bug3782\HelloWorld)\|(ArrayAccess&Bug3782\HelloWorld).',`
`252`	`256`	`11,`
`253`	`257`	`],`
`254`	`258`	`]);`
Original file line number	Diff line number	Diff line change
`@@ -508,3 +508,13 @@ private function postprocess(array $versionData): array`
`508`	`508`	`return $versionData;`
`509`	`509`	`}`
`510`	`510`	`}`
	`511`	`+`
	`512`	`+class OnBool`
	`513`	`+{`
	`514`	`+`
	`515`	`+ public function doFoo(bool $b)`
	`516`	`+ {`
	`517`	`+ $b['foo'] = 1;`
	`518`	`+ }`
	`519`	`+`
	`520`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ function GetASCConfig()`
`53`	`53`	`{`
`54`	`54`	`assertType('array<string>\|true', $result);`
`55`	`55`	`$result['bsw'] = 1;`
`56`		`- assertType('ERROR', $result); // should be non-empty-array<string\|1>&hasOffsetValue('bsw', 1)`
	`56`	`+ assertType("non-empty-array<1\|string>&hasOffsetValue('bsw', 1)", $result);`
`57`	`57`	`}`
`58`	`58`	`else`
`59`	`59`	`{`
`@@ -62,7 +62,7 @@ function GetASCConfig()`
`62`	`62`	`assertType('NEVER', $result); // should be non-empty-array<string\|int>&hasOffsetValue('bsw', int)`
`63`	`63`	`}`
`64`	`64`
`65`		`- assertType('ERROR', $result); // should have a better result`
	`65`	`+ assertType("non-empty-array<1\|string>&hasOffsetValue('bsw', 1)", $result); // should have an int`
`66`	`66`
`67`	`67`	`if (!isset($result['bew']))`
`68`	`68`	`{`
`@@ -73,7 +73,7 @@ function GetASCConfig()`
`73`	`73`	`$result['bew'] = (int) $result['bew'];`
`74`	`74`	`}`
`75`	`75`
`76`		`- assertType('array{bew: int}', $result); // missing bsw key`
	`76`	`+ assertType("non-empty-array<int\|string>&hasOffsetValue('bsw', 1)", $result); // missing bsw key`
`77`	`77`
`78`	`78`	`foreach (['utc', 'ssi'] as $field)`
`79`	`79`	`{`
`@@ -84,7 +84,7 @@ function GetASCConfig()`
`84`	`84`	`}`
`85`	`85`	`}`
`86`	`86`
`87`		`- assertType("non-empty-array<'bew'\|'dberror'\|'result'\|'ssi'\|'utc', 'xyz'\|int\|false>", $result); // should be non-empty-array<int\|string\|false>`
	`87`	`+ assertType("non-empty-array<int\|string\|false>", $result);`
`88`	`88`
`89`	`89`	`return $result;`
`90`	`90`	`}`