A list should only accept lists

VincentLanglet · VincentLanglet · commit 13b6747fee78 · 2024-09-19T16:51:51.000+02:00
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -303,6 +303,10 @@ public function acceptsWithReason(Type $type, bool $strictTypes): AcceptsResult
 			return AcceptsResult::createFromBoolean(count($type->keyTypes) === 0);
 		}
 
+		if ($this->isList()->yes() && $type->isList()->no()) {
+			return AcceptsResult::createNo();
+		}
+
 		$result = AcceptsResult::createYes();
 		foreach ($this->keyTypes as $i => $keyType) {
 			$valueType = $this->valueTypes[$i];
diff --git a/tests/PHPStan/Rules/Generators/YieldFromTypeRuleTest.php b/tests/PHPStan/Rules/Generators/YieldFromTypeRuleTest.php
@@ -39,7 +39,6 @@ public function testRule(): void
 			[
 				'Generator expects value type array{DateTime, DateTime, stdClass, DateTimeImmutable}, array{0: DateTime, 1: DateTime, 2: stdClass, 4: DateTimeImmutable} given.',
 				74,
-				'Array does not have offset 3.',
 			],
 			[
 				'Result of yield from (void) is used.',
diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -841,4 +841,15 @@ public function testClosureBind(): void
 		]);
 	}
 
+	public function testBug11600(): void
+	{
+		$this->checkThisOnly = false;
+		$this->analyse([__DIR__ . '/data/bug-11600.php'], [
+			[
+				'Parameter #1 $array of static method Bug10600\HelloWorld::sayHello() expects array{1, 2}, array{1: 2, 0: 1} given.',
+				18,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-11600.php b/tests/PHPStan/Rules/Methods/data/bug-11600.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Bug10600;
+
+class HelloWorld
+{
+	/** @param array{1, 2} $array */
+	public static function sayHello(array $array): void
+	{
+		array_values($array)[0];
+	}
+}
+
+$a = [0 => 1, 1 => 2];
+$b = [1 => 2, 0 => 1];
+
+HelloWorld::sayHello($a);
+HelloWorld::sayHello($b);

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ public function testRule(): void`
`39`	`39`	`[`
`40`	`40`	`'Generator expects value type array{DateTime, DateTime, stdClass, DateTimeImmutable}, array{0: DateTime, 1: DateTime, 2: stdClass, 4: DateTimeImmutable} given.',`
`41`	`41`	`74,`
`42`		`- 'Array does not have offset 3.',`
`43`	`42`	`],`
`44`	`43`	`[`
`45`	`44`	`'Result of yield from (void) is used.',`