TypeSpecifier - observe hasSideEffects() for static methods

ondrejmirtes · ondrejmirtes · commit 1182199bcffb · 2022-05-27T16:28:49.000+02:00
diff --git a/src/Analyser/TypeSpecifier.php b/src/Analyser/TypeSpecifier.php
@@ -1204,6 +1204,28 @@ public function create(
 			}
 		}
 
+		if (
+			$expr instanceof StaticCall
+			&& $expr->name instanceof Node\Identifier
+			&& $scope !== null
+		) {
+			$methodName = $expr->name->toString();
+			if ($expr->class instanceof Name) {
+				$calledOnType = $scope->resolveTypeByName($expr->class);
+			} else {
+				$calledOnType = $scope->getType($expr->class);
+			}
+
+			$methodReflection = $scope->getMethodReflection($calledOnType, $methodName);
+			if ($methodReflection === null || $methodReflection->hasSideEffects()->yes()) {
+				if (isset($resultType) && !TypeCombinator::containsNull($resultType)) {
+					return $this->createNullsafeTypes($rootExpr, $originalExpr, $scope, $context, $overwrite, $type);
+				}
+
+				return new SpecifiedTypes([], [], false, [], $rootExpr);
+			}
+		}
+
 		$sureTypes = [];
 		$sureNotTypes = [];
 		$exprString = $this->printer->prettyPrintExpr($expr);
diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -894,6 +894,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/non-empty-string-substr-specifying.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/unset-conditional-expressions.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/conditional-types-inference.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7210.php');
 	}
 
 	/**
diff --git a/tests/PHPStan/Analyser/data/bug-7210.php b/tests/PHPStan/Analyser/data/bug-7210.php
@@ -0,0 +1,34 @@
+<?php
+
+namespace Bug7210;
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld {
+	public function doStuff(): void {
+		if (self::getBool()) {
+			return;
+		}
+
+		assertType('bool', self::getBool());
+	}
+
+	/** @phpstan-impure */
+	private static function getBool(): bool {
+		return mt_rand(0, 1) === 0;
+	}
+}
+
+class HelloWorld2 {
+	public function doStuff(): void {
+		if (self::getBool()) {
+			return;
+		}
+
+		assertType('false', self::getBool());
+	}
+
+	private static function getBool(): bool {
+		return mt_rand(0, 1) === 0;
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -894,6 +894,7 @@ public function dataFileAsserts(): iterable`
`894`	`894`	`yield from $this->gatherAssertTypes(__DIR__ . '/data/non-empty-string-substr-specifying.php');`
`895`	`895`	`yield from $this->gatherAssertTypes(__DIR__ . '/data/unset-conditional-expressions.php');`
`896`	`896`	`yield from $this->gatherAssertTypes(__DIR__ . '/data/conditional-types-inference.php');`
	`897`	`+ yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7210.php');`
`897`	`898`	`}`
`898`	`899`
`899`	`900`	`/**`