Optimization: Degrade constant arrays if there's too many values recursively

ondrejmirtes · ondrejmirtes · commit 0cc87f378556 · 2022-09-03T10:46:29.000+02:00
diff --git a/src/Type/TypeCombinator.php b/src/Type/TypeCombinator.php
@@ -597,7 +597,7 @@ private static function processArrayTypes(array $arrayTypes, array $accessoryTyp
 
 		$keyTypesForGeneralArray = [];
 		$valueTypesForGeneralArray = [];
-		$generalArrayOccurred = false;
+		$generalArrayOccurred = self::shouldDegradeConstantArrays($arrayTypes);
 		$constantKeyTypesNumbered = [];
 
 		/** @var int|float $nextConstantKeyTypeIndex */
@@ -644,6 +644,34 @@ private static function processArrayTypes(array $arrayTypes, array $accessoryTyp
 		);
 	}
 
+	/**
+	 * @param ArrayType[] $arrayTypes
+	 */
+	private static function shouldDegradeConstantArrays(array $arrayTypes): bool
+	{
+		$constantArrayValuesCount = 0;
+		foreach ($arrayTypes as $arrayType) {
+			TypeTraverser::map($arrayType, static function (Type $type, callable $traverse) use (&$constantArrayValuesCount): Type {
+				if ($type instanceof ConstantArrayType) {
+					$constantArrayValuesCount += count($type->getValueTypes());
+					if ($constantArrayValuesCount > ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT) {
+						return $type;
+					}
+
+					return $traverse($type);
+				}
+
+				if ($type instanceof UnionType || $type instanceof IntersectionType) {
+					return $traverse($type);
+				}
+
+				return $type;
+			});
+		}
+
+		return $constantArrayValuesCount > ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT;
+	}
+
 	/**
 	 * @param Type[] $constantArrays
 	 * @return Type[]
