Report FILTER_SANITIZE_STRING as deprecated in PHP8.1+#112
Closed
staabm wants to merge 5 commits intophpstan:1.2.xfrom
Closed
Report FILTER_SANITIZE_STRING as deprecated in PHP8.1+#112staabm wants to merge 5 commits intophpstan:1.2.xfrom
staabm wants to merge 5 commits intophpstan:1.2.xfrom
Conversation
staabm
commented
Mar 3, 2024
Comment on lines
+59
to
+61
| // handle `@deprecated 7.3` as a min php version constraint. | ||
| // this notation is used in jetbrains/phpstorm-stubs | ||
| sscanf($deprecatedMessage ?? '', '%d.%d', $phpMajor, $phpMinor); |
Contributor
Author
There was a problem hiding this comment.
we interpret the annotation from phpstorm-stubs
that way we can support all constants out of the box, without the need for a hardcoded list in this class
Member
There was a problem hiding this comment.
This logic isn't needed here at all. This should be handled by PhpStormStubsSourceStubber.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression test for phpstan/phpstan#10662
requires a fix in phpstan-src
todo: raise min phpstan version in composer.json