Merged
Conversation
e6b5463 to
f2349fe
Compare
ondrejmirtes
requested changes
Oct 5, 2019
src/Analyser/MutatingScope.php
Outdated
| } | ||
| return TypeCombinator::union(...$newTypes); | ||
| } elseif ($varType instanceof IntegerRangeType) { | ||
| return $varType->generalize(); |
src/Type/IntegerRangeType.php
Outdated
| /** @var int */ | ||
| private $max; | ||
|
|
||
| public function __construct(?int $min, ?int $max) |
Member
There was a problem hiding this comment.
Make constructor private and always use fromInterval?
src/Type/IntegerRangeType.php
Outdated
| } | ||
|
|
||
| if ($type instanceof ConstantIntegerType) { | ||
| return $this->min === $type->getValue() && $this->max === $type->getValue(); |
Member
There was a problem hiding this comment.
IntegerRangeType(X, X) shouldn't be created in the first place?
| [ | ||
| [ | ||
| new IntegerRangeType(1, 3), | ||
| new IntegerRangeType(7, 9), |
Member
There was a problem hiding this comment.
No test for union of range + constant integer (inside and outside)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.