You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe we can simplify phpstan-phpunit, phpstan-beberlei-assert, phpstan-webmozart-assert since these libraries already have @psalm-assert annotations.
BUT: It already happened that PHPStan extension was more correct and precise than these annotations so we need to keep the tests
BUT: We need to investigate which version of these libraries added those annotations. I'd say if it's longer than three years we can safely remove redundant extensions, otherwise not.
We can definitely remove extensions for new methods in these libraries that were already added with those assert annotations.
UnionTypeMethodReflection::getAssertions() needs to be fixed. The logic to compute which annotations to use might be non-trivial.
IntersectionTypeMethodReflection::getAssertions() needs to be fixed. The logic to compute which annotations to use might be non-trivial.
Feature request
@phpstan-assertstub it's fine again. This might be worth investigation and maybe fixing it.@psalm-assertannotations.UnionTypeMethodReflection::getAssertions()needs to be fixed. The logic to compute which annotations to use might be non-trivial.IntersectionTypeMethodReflection::getAssertions()needs to be fixed. The logic to compute which annotations to use might be non-trivial.