Skip to content

Analysis of a file with + operator on array shapes takes forever #6936

@staabm

Description

@staabm

Bug report

analysing this code runs for 2-3 minutes. it involves UnionTypes with 263169 elements and more

<?php

class clxAuftragController
{
	public function save_auftrag_changes()
	{
		foreach ($_POST['adansch'] as $avkid => $adansch) {
			$change = 0;
			$col = [];
			if ($adansch['telefon'] != $aktueller_endkunde->telefon && '' != $adansch['telefon']) {
				$col['telefon'] = $adansch['telefon'];
				$change = 1;
			}
			if ($adansch['email'] != $aktueller_endkunde->email && '' != $adansch['email']) {
				$col['email'] = $adansch['email'];
				$change = 1;
			}
			if ($adansch['fa_gruendungsjahr'] != $aktueller_endkunde->fa_gruendungsjahr) {
				$col['fa_gruendungsjahr'] = $adansch['fa_gruendungsjahr'];
				$change = 1;
			}
			if ($adansch['fa_geschaeftsfuehrer'] != $aktueller_endkunde->fa_geschaeftsfuehrer) {
				$col['fa_geschaeftsfuehrer'] = $adansch['fa_geschaeftsfuehrer'];
				$change = 1;
			}
			if ($adansch['handelregnr'] != $aktueller_endkunde->handelregnr) {
				$col['handelregnr'] = $adansch['handelregnr'];
				$change = 1;
			}
			if ($adansch['amtsgericht'] != $aktueller_endkunde->amtsgericht) {
				$col['amtsgericht'] = $adansch['amtsgericht'];
				$change = 1;
			}
			if ($adansch['ustid'] != $aktueller_endkunde->ustid) {
				$col['ustid'] = $adansch['ustid'];
				$change = 1;
			}
			if ($adansch['ustnr'] != $aktueller_endkunde->ustnr) {
				$col['ustnr'] = $adansch['ustnr'];
				$change = 1;
			}

			if ($adansch['firma'] != $aktueller_endkunde->firma) {
				$col['firma'] = $adansch['firma'];
				$change = 1;
			}

			if (1 == $change) {
				// MobisHelper::createXmlDataJob("ada",(int)$aktueller_endkunde->adaid, $col);
				if (!isset($_SENDJOB[$avk->avkid]['ada'][$aktueller_endkunde->adaid])) {
					$_SENDJOB[$avk->avkid]['ada'][$aktueller_endkunde->adaid] = [];
				}

				$_SENDJOB[$avk->avkid]['ada'][$aktueller_endkunde->adaid] = $_SENDJOB[$avk->avkid]['ada'][$aktueller_endkunde->adaid] + $col;
			}
		}
	}
}

I am already working on a fix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions