I'm refactoring Larastan's test suite to use RuleTestCase instead of our own slow solution.

But I hit a wall during the refactor 😄

We have a custom TypeNodeResolverExtension. It's logic depends on a parameter defined in the config. And registered in config to change it accordingly.

This test provides a custom config file to override the checkModelProperties

The problem

When the test is ran with ./vendor/bin/phpunit --filter='testModelPropertyRuleOnModelFactory' it fails. Because the expected error did not happen. But if I run PHPStan directly with ./vendor/bin/phpstan analyse -vvv --debug -c tests/Rules/Data/modelPropertyConfig.neon tests/Rules/Data/model-property-model-factory.php -l9 I see the correct error.

I debugged it with XDebug little bit. And I suspect that it's related to the caching in LazyTypeNodeResolverExtensionRegistryProvider, PHPStan is doing while testing. Because when phpunit first runs, it collects data in the data providers. Since Larastan has some dataProviders with gatherAssertTypes, it triggers the LazyTypeNodeResolverExtensionRegistryProvider. Then when the actual test runs, it uses the old data.

What I tried?

• I tried to make the active flag in ModelPropertyTypeNodeResolverExtension static. Didn't help. Called the new static method in setUp methods in test classes. Didn't help.
• I added autowired: false to the ModelPropertyTypeNodeResolverExtension, tried setup to set the active flag. Didn't help.

It's easily reproducible in the test-refactors of Larastan. I did not spend time to create a new repository, because I'm sure the rest of the Larastan has no effect on this bug. I verified this by removing the include in the config file.

Does anyone have any idea? Because I'm going little bit crazy 😅