Replies: 1 comment 6 replies
-
|
Can you actually make PHPStan return $hash = password_hash($input, PASSWORD_DEFAULT); |
Beta Was this translation helpful? Give feedback.
-
|
This function needs a dynamic return type extension. Please contribute it, or open a bug report. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, thanks. Issue created here: #5978 I'm not familiar with PHPStan internals, what you mean by "function needs a dynamic return type extension"? Can you point me somewhere this is documented? |
Beta Was this translation helpful? Give feedback.
-
|
See https://phpstan.org/developing-extensions/dynamic-return-type-extensions or phpstan/phpstan-src#756 for an example that is currently being worked on |
Beta Was this translation helpful? Give feedback.
-
|
@mkoske do you plan to work on a fix? I recently added a new DynamicReturnTypeExtension.. you might get some inspiration from the phpstan/phpstan-src#766 |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, but I don't have time. If you want to work on it, please do that. Thanks! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
is this reporting correct?
PHP documentation site says
password_hashreturnsstringbut PHP docs in VSCode saysstring|false|null. And if I check for false and null, phpstan reports it.If I try in PHP with invalid algorithm (e.g.
password_hash("input", "non-existent algorithm"), it does returnnullbut also generates a warning. I have no idea in what conditions it could returnfalse.https://phpstan.org/r/1ab1e0c7-e641-4e54-9037-46af0e4f37fa
Br, Miika
Beta Was this translation helpful? Give feedback.
All reactions