Replies: 1 comment
-
|
The difference between This means that native type does not take any extensions into account, because they might be wrong. getNativeType only uses native types. I think it should remain like this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In rectorphp/rector-src#6880 I see rector trusting a array-shape from a userland method and applies code-tranformations based on it. I think thats pretty risky and should not be done.
but in contrast, I also see code which is based on builtin functions, for which I think the array-shape can be trusted.
I wonder whether from phpstan-src side, we should make the array-shape when returned from a php-src builtin function a native-type, while the array-shape based on userland phpdoc should be a phpdoc-type only.. in terms of
$scope->getType() vs. $scope->getNativeType()wdyt?
Beta Was this translation helpful? Give feedback.
All reactions