PHPStan 2.1.3 / 2.1.4 prophecy Plugin: Internal error: assert($calledOnType instanceof Type\Generic\GenericObjectType) while analysing file #12556
Replies: 1 comment 11 replies
-
|
Hey, PHPStan for such code reports this error: https://phpstan.org/r/29167c4e-3431-4de2-b6df-1c63f0c9930c
That's why PHPStan crashes for that so you should address this in a different way and not by adding yet another What you want instead of this |
Beta Was this translation helpful? Give feedback.
-
|
If that PR has some failing tests so that I can clearly understood what's the goal I'll take a look. |
Beta Was this translation helpful? Give feedback.
-
|
@ondrejmirtes yes the PR contains more complex test case to reproduce the issue with intersect type. |
Beta Was this translation helpful? Give feedback.
-
|
@alexander-schranz I checked out the $ vendor/bin/phpunit
PHPUnit 9.6.22 by Sebastian Bergmann and contributors.
Runtime: PHP 8.4.1
Configuration: /Users/ondrej/Downloads/phpstan-prophecy/phpunit.xml
................. 17 / 17 (100%)
Time: 00:00.064, Memory: 12.00 MB
OK (17 tests, 42 assertions)Please provide a test that fails. |
Beta Was this translation helpful? Give feedback.
-
|
I can see that PHPStan analysis fails, should I look into that instead? |
Beta Was this translation helpful? Give feedback.
-
|
Here's my answer Jan0707/phpstan-prophecy#366 (comment) |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello @ondrejmirtes,
maybe you can help us out here. In the prophecy plugin we have an issue now and I'm not yet sure what the best solution is.
https://github.com/Jan0707/phpstan-prophecy/blob/8870b158f2197b7803167d581a6c3b3a9c44aae4/src/Type/ObjectProphecy/WillExtendOrImplementDynamicReturnTypeExtension.php#L98
Jan0707/phpstan-prophecy#365
I was thinking of:
\assert( $calledOnType instanceof Type\Generic\GenericObjectType + || $calledOnType instanceof Type\Generic\GenericStaticType, 'Unexpected: ' . $calledOnType::class ); return new Type\Generic\GenericObjectType( Prophecy\ObjectProphecy::class, [ Type\TypeCombinator::intersect( new Type\ObjectType($className), ...$calledOnType->getTypes(), ), ], );but not sure.
Beta Was this translation helpful? Give feedback.
All reactions