Detect invalid service in conditionalTags

ondrejmirtes · ondrejmirtes · commit 400acf6e48cb · 2019-03-11T11:39:19.000+01:00
diff --git a/src/DependencyInjection/ConditionalTagsExtension.php b/src/DependencyInjection/ConditionalTagsExtension.php
@@ -11,7 +11,11 @@ public function beforeCompile(): void
 		$builder = $this->getContainerBuilder();
 
 		foreach ($config as $type => $tags) {
-			foreach ($builder->findByType($type) as $service) {
+			$services = $builder->findByType($type);
+			if (count($services) === 0) {
+				throw new \PHPStan\ShouldNotHappenException(sprintf('No services of type "%s" found.', $type));
+			}
+			foreach ($services as $service) {
 				foreach ($tags as $tag => $parameter) {
 					if ((bool) $parameter) {
 						$service->addTag($tag);
