Require whitespace before description with limited start tokens#128
Merged
ondrejmirtes merged 1 commit intophpstan:1.5.xfrom Jun 8, 2022
Merged
Require whitespace before description with limited start tokens#128ondrejmirtes merged 1 commit intophpstan:1.5.xfrom
ondrejmirtes merged 1 commit intophpstan:1.5.xfrom
Conversation
Member
|
I really like this! I'm gonna check the integration tests in PHPStan before tagging a release here because there might be some real-world impact. |
Member
|
Thank you! |
mvorisek
reviewed
Jun 8, 2022
| new PhpDocTagNode( | ||
| '@return', | ||
| new InvalidTagValueNode( | ||
| '\Closure(...int, string): string', |
Contributor
There was a problem hiding this comment.
thank you for throwing at least
as all other types in \Closure phpdoc does not require a variable name, can support for unnamed variadic phpdoc be added?
Contributor
Author
There was a problem hiding this comment.
It is already supported, but the type always has to come first.
Contributor
There was a problem hiding this comment.
I didn't know, thank you ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125