We should be able to do this without breaking BC. Because @param without a type is essentially useless, I feel like we shouldn't mix it with other useful @param tags that have a type.

So my suggestion is:

1. Do not make $type in src/Ast/PhpDoc/ParamTagValueNode.php nullable.
2. Create a separate TypelessParamTagValueNode that can still carry $description.
3. PhpDocNode::getParamTagValues() WIL NOT return TypelessParamTagValueNode, it needs to be filtered out.
4. Add PhpDocNode::getTypelessParamTagValues().
5. I'll release that in minor phpdoc-parser version.
6. Add some tests to phpstan-src that demonstrate this is no longer a parse error, and potentially get and make use of some data carried by getTypelessParamTagValues() (but I don't think we use parameter description anywhere).

Thank you!

Perfect, thank you!

Thank you Ondřej and Richard!

This one made our baseline files thinner by ~3k entries 🙈 I am not 100% convinced that this is good behaviour but I understand the reasoning behind it. Cheers! 🍻

Is it possible to revert the old behavior by configuration flag?

Why?

It was useful for us to detect this errors because they are usually show old code with bad type hinting (in our code base). We check and fix them step by step. So we need to stay at 1.7.11 version before will fix them all.

@p-golovin As said earlier in this thread, you'll get the same errors on level 6 (missing parameter typehint).

@ondrejmirtes Thank you. We'll try to raise level to 6 (now we make fixes on level 3).

As said earlier in this thread, you'll get the same errors on level 6 (missing parameter typehint).

Really? We're on level 6 and upgrading caused many "ignored ... not found", so we had to regenerate baselines and maaaaaaany ignores were removed. 🤔

EDIT: remember, do not comment when too tired to understand 😉

see #77 (comment)