Skip to content

Add compatibility for PHP 8.5#1500

Merged
torchello merged 10 commits intophpspec:mainfrom
torchello:php8.5
Jan 24, 2026
Merged

Add compatibility for PHP 8.5#1500
torchello merged 10 commits intophpspec:mainfrom
torchello:php8.5

Conversation

@torchello
Copy link
Copy Markdown
Contributor

@torchello torchello commented Nov 9, 2025

Resolving #1499

  1. Update composer.json/lock
  2. Update README
  3. Add 8.5 to CI

@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Nov 9, 2025

@andypost seems like 8.5 should be added to Prophecy first 🤔

@andypost
Copy link
Copy Markdown
Contributor

andypost commented Nov 11, 2025

yes, related phpspec/prophecy#656

stof
stof reviewed Nov 12, 2025
View reviewed changes
@stof
Copy link
Copy Markdown
Member

stof commented Dec 1, 2025

I think we should split the CI workflow into different jobs. Coding standard checks and static analysis don't need to be done for all PHP versions, which would allow us to decouple the PHP versions being tested from versions supported by our static analysis tooling.

@dbu dbu mentioned this pull request Dec 10, 2025
Open
1 task
@torchello torchello requested review from andypost and stof December 16, 2025 15:11
@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Dec 17, 2025

@stof @andypost please have another look! thanks!

@wesolydexter
Copy link
Copy Markdown

wesolydexter commented Jan 7, 2026

Can you merge this? Are there any contraindications?

This was referenced Jan 8, 2026
Closed
Merged
@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Jan 9, 2026

Ping @stof @MarcelloDuarte

@chives
Copy link
Copy Markdown

chives commented Jan 9, 2026

I've tried to use phpspec on PHP 8.5 with this PR merged and noticed that there are some deprecations that should be avoided on PHP 8.5. Here are the changes to achieve that:

@chives chives mentioned this pull request Jan 9, 2026
Merged
1 task
@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Jan 14, 2026

Hey @chives ! Thanks, I will apply your changes.

@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Jan 15, 2026

Requires #1503

theofidry
theofidry reviewed Jan 15, 2026
View reviewed changes
@torchello torchello force-pushed the php8.5 branch 2 times, most recently from af2bb83 to eedc815 Compare January 21, 2026 08:20
@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Jan 21, 2026

Rebased and CI is green.

@torchello
Copy link
Copy Markdown
Contributor Author

torchello commented Jan 21, 2026

@stof @andypost mind doing final review?

@torchello torchello merged commit 4aa1d99 into phpspec:main Jan 24, 2026
16 checks passed
@torchello torchello mentioned this pull request Jan 25, 2026
Closed
@umpirsky
Copy link
Copy Markdown

umpirsky commented Mar 3, 2026

This is great, when can we expect the new relase that includes this? Thanks!

@wesolydexter
Copy link
Copy Markdown

wesolydexter commented Mar 4, 2026

Already released:
https://github.com/phpspec/phpspec/releases/tag/8.2.0

@umpirsky
Copy link
Copy Markdown

umpirsky commented Mar 4, 2026

Oh, sorry, I asked in the wrong PR, I meant to do it in #1510, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andypost andypost Awaiting requested review from andypost

@stof stof Awaiting requested review from stof

1 more reviewer

@theofidry theofidry theofidry left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@torchello @andypost @stof @wesolydexter @chives @umpirsky @theofidry