Skip to content

Allow PHPUnit 11#1485

Closed
DanielBadura wants to merge 2 commits intophpspec:mainfrom
DanielBadura:allow-phpunit-11
Closed

Allow PHPUnit 11#1485
DanielBadura wants to merge 2 commits intophpspec:mainfrom
DanielBadura:allow-phpunit-11

Conversation

@DanielBadura
Copy link
Copy Markdown
Contributor

@DanielBadura DanielBadura commented Apr 2, 2025

Same changes as in #1483 but from a more up to date state so that psalm 6 is allowed which enables the installation of PHPUnit 11.

Also updates psalm baseline & configuration due to new errors reported by psalm newest minor versions.

…omplain about calculating int's with float's.

Removed supressed error: Is fixed upstream.
Add 4 new baseline entries: complaining about not available method during magic method resolution.
xmlns="https://getpsalm.org/schema/config"
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
errorBaseline="psalm-baseline.xml"
ensureOverrideAttribute="false"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resulted in ~370 errors. I let you decide if you want to force this - I excluded it for this patch now since it would bloat this patch.

xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
errorBaseline="psalm-baseline.xml"
ensureOverrideAttribute="false"
strictBinaryOperands="false"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resulted in ~10 errors, all about multiplying a float with an int.

@Jean85
Copy link
Copy Markdown
Contributor

Jean85 commented Apr 29, 2025

@DanielBadura does this need a rebase, since #1484 got merged?

@DanielBadura
Copy link
Copy Markdown
Contributor Author

If I remember correctly I did the PR after the merge, but I'll rebase again in 10min

@DanielBadura
Copy link
Copy Markdown
Contributor Author

I created this PR after the merge, so no rebase needed.

@Jean85
Copy link
Copy Markdown
Contributor

Jean85 commented Apr 29, 2025

@stof sorry for pinging you again... Can we merge this? It unlocks PHPUnit 12 for Prophecy: phpspec/prophecy-phpunit#67

@MarcelloDuarte
Copy link
Copy Markdown
Member

@Jean85 are you happy for me to merge this? And are you free sometime today for a quick chat, to help me release updates for PHPUnit 11, Symfony and PHP 8.3?

I am already working on 8.4 support.

@Jean85
Copy link
Copy Markdown
Contributor

Jean85 commented Apr 29, 2025

@MarcelloDuarte very happy to be of help! I may have some time today to do it; let me know how I can be of help.

You can reach me via email looking at my author field, on phpc.social, on multiple Discord servers (PHP-FIG's, PHPC, Sentry...) or on some Slack (Grusp, Symfony, Avanscoperta).

@MarcelloDuarte
Copy link
Copy Markdown
Member

@Jean85 Cool 👍 sent you an invite

@Jean85 Jean85 mentioned this pull request Apr 30, 2025
@DanielBadura
Copy link
Copy Markdown
Contributor Author

Closing it here, as it seems the first commit was cherry-picked is part of the newest release: https://github.com/phpspec/phpspec/releases/tag/7.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants