Extract function to load services from services file #20015
Merged
+100
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts to ContainerBuilder::loadServices(), removes service alias support and add unit tests. Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20015 +/- ##
============================================
+ Coverage 62.14% 62.17% +0.02%
- Complexity 16099 16104 +5
============================================
Files 676 676
Lines 59981 59991 +10
============================================
+ Hits 37274 37297 +23
+ Misses 22707 22694 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
williamdes
approved these changes
Jan 8, 2026
Member
williamdes
left a comment
There was a problem hiding this comment.
Is it now easier to implement php-di?
Member
Author
Yes, but more because of #20013 than this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts to
ContainerBuilder::loadServices(), removes service alias support and add unit tests.