-
Notifications
You must be signed in to change notification settings - Fork 369
change pecl url from http to https #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@iliubang please remove the changes in |
|
@morozov I have removed the changes in |
|
Thank you. What about the rest of the URLs? |
|
@morozov The rest of the URLs do not need to switch to HTTPS. |
|
@iliubang Why not? There's an HTTPS mirror of http://www.php.net/ at https://secure.php.net/. http://museum.php.net/ is indeed inaccessible via HTTPS. @jhdxr do you have any objections? Switching to HTTPS means that installing PHP itself or PECL extensions will require PHP compiled with OpenSSL. |
|
@morozov nope, but I suggest we'd better offer an option for it, like |
|
@jhdxr do you mean options like The first would make more sense if PHPBrew controlled the web servers where it downloads packages from (like Composer and Packagist, see composer/composer#5436). Otherwise, if at some point php.net starts redirecting from HTTP to HTTPs, those switches will become useless. As for the second, what kind of problems with local environment do you mean? The only valid case I'm aware of when a user wants to disable certificate check is for testing their own service with self-signed certificates. Is there another case when it's needed? |
| "corneltek/pearx": "dev-master", | ||
| "corneltek/curlkit": "@dev", | ||
| "liubang/pearx": "dev-master", | ||
| "liubang/curlkit": "@dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please send the PR to the upstream repo ? thanks.
| { | ||
| const NAME = 'phpbrew'; | ||
| const VERSION = '1.23.1'; | ||
| const VERSION = '1.23.2'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the version change ? thanks
|
@iliubang please rebase |
|
I'm sorry I accidentally deleted the fork, I have no good way to deal with it now. Could you please delete this PR, or tell me some good idea to handle it. |
No description provided.