Skip to content

Conversation

@liubang
Copy link

@liubang liubang commented Feb 26, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 26, 2018

Coverage Status

Coverage remained the same at 52.298% when pulling 83ccde3 on iliubang:master into 581eb9c on phpbrew:master.

@morozov
Copy link
Contributor

morozov commented Feb 26, 2018

@iliubang please remove the changes in bin/phpbrew. This file will be rebuild once a new version is released. Do you also mind changing all http://*.php.net URLs for consistency?

@liubang
Copy link
Author

liubang commented Feb 26, 2018

@morozov I have removed the changes in bin/phpbrew.

@morozov
Copy link
Contributor

morozov commented Feb 26, 2018

Thank you. What about the rest of the URLs?

@liubang
Copy link
Author

liubang commented Feb 26, 2018

@morozov The rest of the URLs do not need to switch to HTTPS.

@liubang liubang changed the title change pecl rest url from http to https change pecl url from http to https Feb 26, 2018
@morozov
Copy link
Contributor

morozov commented Feb 26, 2018

@iliubang Why not? There's an HTTPS mirror of http://www.php.net/ at https://secure.php.net/. http://museum.php.net/ is indeed inaccessible via HTTPS.

@jhdxr do you have any objections? Switching to HTTPS means that installing PHP itself or PECL extensions will require PHP compiled with OpenSSL.

@morozov morozov mentioned this pull request Feb 26, 2018
@jhdxr
Copy link
Member

jhdxr commented Feb 26, 2018

@morozov nope, but I suggest we'd better offer an option for it, like --ansi / --no-ansi, since sometimes there might be some problem with the local environment during certificate check.

@morozov
Copy link
Contributor

morozov commented Feb 26, 2018

@jhdxr do you mean options like --ssl / --no-ssl which would enable/disable the usage of HTTPS when fetching resources or something like --no-check-certificate in wget which will disable checking the certificate signature?

The first would make more sense if PHPBrew controlled the web servers where it downloads packages from (like Composer and Packagist, see composer/composer#5436). Otherwise, if at some point php.net starts redirecting from HTTP to HTTPs, those switches will become useless.

As for the second, what kind of problems with local environment do you mean? The only valid case I'm aware of when a user wants to disable certificate check is for testing their own service with self-signed certificates. Is there another case when it's needed?

"corneltek/pearx": "dev-master",
"corneltek/curlkit": "@dev",
"liubang/pearx": "dev-master",
"liubang/curlkit": "@dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please send the PR to the upstream repo ? thanks.

{
const NAME = 'phpbrew';
const VERSION = '1.23.1';
const VERSION = '1.23.2';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the version change ? thanks

@kevinnio
Copy link
Contributor

kevinnio commented Oct 29, 2018

@iliubang please rebase master so your Travis build gets fixed.

@liubang
Copy link
Author

liubang commented Oct 30, 2018

I'm sorry I accidentally deleted the fork, I have no good way to deal with it now. Could you please delete this PR, or tell me some good idea to handle it.

@jhdxr jhdxr mentioned this pull request Dec 22, 2018
@jhdxr jhdxr closed this in ceb31b5 Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants