Skip to content

Add a fluent api to work with fg/bg colors and modifiers #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dantleech merged 13 commits into from
Nov 17, 2023
Merged

Add a fluent api to work with fg/bg colors and modifiers #136

dantleech merged 13 commits into from
Nov 17, 2023

Conversation

@KennedyTedesco
Copy link
Contributor

@KennedyTedesco KennedyTedesco commented Nov 17, 2023 •
edited
Loading

Partially closes: #109

With this feature, instead of:

Span::styled('[q]', Style::default()->fg(AnsiColor::Red))

We just:

Span::fromString('[q]')->red()

Next step (a new PR): I'll implement a parser, something like:

Line::parse('<fg=green options=bold,italic>Hello</> World')

dantleech
dantleech reviewed Nov 17, 2023
View reviewed changes
@dantleech dantleech merged commit 908ba2e into php-tui:main Nov 17, 2023
@dantleech
Copy link
Collaborator

dantleech commented Nov 17, 2023

🎉 nice!

@KennedyTedesco KennedyTedesco deleted the style branch November 17, 2023 22:05
@KennedyTedesco KennedyTedesco mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dantleech dantleech Awaiting requested review from dantleech

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encapsulate the modifier from the user in Style

2 participants

@KennedyTedesco @dantleech