Add functions with conditional return types#73
Merged
szepeviktor merged 1 commit intophp-stubs:masterfrom Apr 15, 2023
Merged
Conversation
Member
|
Thank you very much! So should I remove all these extensions from phpstan-wordpress in the near future? |
Contributor
Author
Depends on the supported versions of WP or wordpress-stubs respectively. Also, we should check if the extensions are fully covered by conditional return types. |
Contributor
|
I'd say if you remove them you should bump the required min version of the stubs package. Then it should be safe, right? But it essentially comes down to supported WP versions then as @IanDelMar said I guess |
Member
I support WordPress versions < 0 and > 7000000. |
Contributor
|
You say that but secretly you try to be super backwards compatible. Like, ahem, WordPress xD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functions to the map using conditional return types that are currently handled via return type extensions in szepeviktor/phpstan-wordpress.
Also adds
get_post_types()(szepeviktor/phpstan-wordpress#177).Not thoroughly tested yet.