Conversation
This commit removes a large number of `@var` docblocks from constants throughout the `Psl\DateTime` and `Psl\Math` namespaces. These annotations were often redundant, too wide (e.g., `@var int` for a specific literal value), or in some cases, incorrect. modern static analyzers can infer the precise literal types of these constants directly from their values. Signed-off-by: azjezz <azjezz@protonmail.com>
Pull Request Test Coverage Report for Build 17871211749Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes a large number of
@vardocblocks from constants throughout thePsl\DateTimeandPsl\Mathnamespaces.These annotations were often redundant, too wide (e.g.,
@var intfor a specific literal value), or in some cases, incorrect. modern static analyzers can infer the precise literal types of these constants directly from their values.