Skip to content

mark password as a sensitive param for 8.2#516

Merged
remicollet merged 3 commits intomasterfrom
issue-sensitive
Jul 28, 2022
Merged

mark password as a sensitive param for 8.2#516
remicollet merged 3 commits intomasterfrom
issue-sensitive

Conversation

@remicollet
Copy link
Copy Markdown
Collaborator

Notice: this imply to use 8.2 to generate arginfo.

php_memcached.c Outdated

#endif

#if PHP_VERSION_ID < 80200
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be defined only for 8.0/8.1, but needed for 7.x because of php/php-src#8842

Copy link
Copy Markdown
Collaborator

@sodabrew sodabrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TimWolla
Copy link
Copy Markdown

TimWolla commented Jul 12, 2022

Note: You'll likely need to update this PR due to php/php-src@342e18f which removes the zend_mark_function_parameter_as_sensitive() function and @sensitive-param in favor of a more generic solution.

@remicollet
Copy link
Copy Markdown
Collaborator Author

Refreshed for upcoming 8.2.0beta1

@remicollet remicollet merged commit ce2dfa5 into master Jul 28, 2022
@remicollet remicollet deleted the issue-sensitive branch July 28, 2022 07:28
@remicollet
Copy link
Copy Markdown
Collaborator Author

CI is not related to this PR, so suashed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants