Conversation
GrahamCampbell
approved these changes
May 17, 2023
Contributor
|
Hmmmm, these changes look correct, but incomplete. Not sure why yet... |
Contributor
Author
|
i gave up with phpspec and converted the test to phpunit. much less clutter imho :) |
dbu
commented
May 17, 2023
| count: 1 | ||
| path: src/EmulatedHttpClient.php | ||
|
|
||
| # we still support the obsolete RequestFactory for BC but do not require the package anymore |
Contributor
Author
There was a problem hiding this comment.
there is something with stubs one can do in phpstan but did not get it to work.
we will get rid of all this when we do a new major version anyways, so did not want to spend more time on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they broke in #226 because we actually relied on php-http/message-factories for tests and it was installed through indirect dependency but no longer...