Conversation
This was referenced May 1, 2020
- Get the tests to pass again. - Use twig PSR4 - Fix a couple of renamed variables in TwigFunctionsScanner
Collaborator
|
That's indeed way cleaner now. |
Collaborator
|
sorry to ask, but btw could you please grant me back the admin role on the repository. |
Member
Author
|
Yes, sorry. You're admin now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@drzraf I've refactored your code to be more aligned with the gettext code.
TwigFunctionsScannerresponsability is just extract the functions in the code.TwigScanneris a generical scanner for twig templatesTimberScannerextendsTwigScannerand has the handlers for the specific timber functions. I think this code should be moved to a different repositoryphp-gettext/timber-scanner, but we can keep it here for now, for convenience.The tests are failing. I'm not very familiarized with Timber or Twig, so just provided a basic structured code as basis.