Skip to content

Conversation

@AhmedGamal
Copy link
Contributor

Default options addition to config and docs for Laravel and Symfony

@yoeunes yoeunes merged commit c35e973 into php-flasher:2.x May 26, 2024
@yoeunes
Copy link
Member

yoeunes commented May 26, 2024

Hi Ahmed,

Thank you so much for this pull request. It's incredibly satisfying to see contributions, especially since it's not often we get a lot of community involvement from the start of the project.

I really appreciate your approach to adding default options, and I think it's a cool idea! I plan to make some tweaks, like moving the default values to the JavaScript part. This adjustment will ensure that the same configuration options are available whether we dispatch a notification from JavaScript or PHP.

If there's anything else you believe we could improve in PHPFlasher, I'm all ears. Although I maintain the project, I don't use it daily in my work, so insights from active users like yourself are invaluable for making PHPFlasher more robust and user-friendly.

Thanks again for your fantastic contribution!

Best regards,
Younes

@yoeunes
Copy link
Member

yoeunes commented May 26, 2024

Hi Ahmed,

Good news! The default options are already set on the JavaScript side. You can see them here: php-flasher/blob/b08161f9. These will be included in the next release.

Thanks for bringing this up, and please let me know if there's anything else we need to look into.

Best regards,
Younes

@AhmedGamal
Copy link
Contributor Author

Hi Yoeunes,

I am so happy you liked this contribution and will be glad to contribute more to this great package I was lucky to install and use.

You did a great job and I think the package fulfilled the most functions any developer would search for.

I have some ideas to give more freedom in customization like an option to disable/enable the progress bar,
and the ability to customize the theme/icons, or have a custom view without digging deeper into the core.

I will always be happy to help and contribute any time to current or future developments.

Best Regards,
Ahmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants