Skip to content

[BC] ResourceMananger no longer allows nullable main_script / root_script #208

@ToshY

Description

@ToshY

Problem

I was trying to upgrade 1.15.14 to 2.1.1 (php-flasher/flasher-symfony ; php-flasher/flasher-sweetalert) and I've found a breaking change regarding Symfony config. Previously, root_script was nullable but now it has been refactored to main_script and by which also the signature has changed to be no longer be nullable.

1.15.14

https://github.com/php-flasher/php-flasher/blame/c06624768dc760dce4a75f74db10c7a24bcaa409/src/Prime/Response/Resource/ResourceManager.php#L57

2.1.1


This now causes issues as root_script: ~ (now main_script: ~) no longer works. My setup has the Javascripts assets @flasher/flasher and @flasher/flasher-sweetalert installed separately with NPM so it can be easily used with Webpack Encore instead of PHP flasher injecting remote/local assets in the head.

Is there a possibility to make this nullable again?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions