Expand Properties and Constants on constants where it makes sense#72
Merged
Crell merged 1 commit intophp-fig:masterfrom Jun 12, 2023
Merged
Expand Properties and Constants on constants where it makes sense#72Crell merged 1 commit intophp-fig:masterfrom
Crell merged 1 commit intophp-fig:masterfrom
Conversation
Collaborator
|
Should we go further and apply the same to enum cases? Edit: Wait, no, we didn't bother making them compacted because no one uses that style. Ignore me. 😄 |
Contributor
|
This makes sense to me. I also think it makes sense to expand the |
Collaborator
|
That makes sense. @samdark, can you expand the wording a bit? |
Member
Author
|
Crell
approved these changes
Jun 12, 2023
Collaborator
|
Valid. OK, let's proceed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.