Skip to content

Expand Properties and Constants on constants where it makes sense#72

Merged
Crell merged 1 commit intophp-fig:masterfrom
samdark:properties-and-constants
Jun 12, 2023
Merged

Expand Properties and Constants on constants where it makes sense#72
Crell merged 1 commit intophp-fig:masterfrom
samdark:properties-and-constants

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented Apr 21, 2023

No description provided.

@Crell
Copy link
Copy Markdown
Collaborator

Crell commented Apr 21, 2023

Should we go further and apply the same to enum cases?

Edit: Wait, no, we didn't bother making them compacted because no one uses that style. Ignore me. 😄

@KorvinSzanto
Copy link
Copy Markdown
Contributor

This makes sense to me. I also think it makes sense to expand the underscore is meaningless directive to include all constructs including variables and enum cases and anything else anyway.

@Crell
Copy link
Copy Markdown
Collaborator

Crell commented Jun 5, 2023

That makes sense. @samdark, can you expand the wording a bit?

@samdark
Copy link
Copy Markdown
Member Author

samdark commented Jun 9, 2023

@Crell

  1. The section is "4.3 Properties and Constants" so variables and other constructs do not fit there.
  2. Underscore is typically used in foreach ($items as $key => $_item) to indicate that only key is needed.

@Crell
Copy link
Copy Markdown
Collaborator

Crell commented Jun 12, 2023

Valid. OK, let's proceed here.

@Crell Crell merged commit 101b589 into php-fig:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants