Add errata detailing addition of scalar type hints for PSR-11 (ContainerInterface)#1215
Merged
Jean85 merged 1 commit intophp-fig:masterfrom Mar 5, 2021
weierophinney:feature/psr-11-evolution
Merged
Add errata detailing addition of scalar type hints for PSR-11 (ContainerInterface)#1215Jean85 merged 1 commit intophp-fig:masterfrom weierophinney:feature/psr-11-evolution
Jean85 merged 1 commit intophp-fig:masterfrom
weierophinney:feature/psr-11-evolution
Conversation
Jean85
reviewed
Jun 19, 2020
Member
Jean85
left a comment
There was a problem hiding this comment.
Formally this change is ok.
As per our bylaw, it will be merged after a successful CC vote.
Contributor
Author
|
Ping @moufmouf — are you okay with this? |
Member
|
Looks decent 👍 |
Member
|
On hold until #1216 goes through. |
This was referenced Jun 26, 2020
ashnazg
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: