Merged
Conversation
mnapoli
approved these changes
Jun 28, 2017
Member
mnapoli
left a comment
There was a problem hiding this comment.
👍 but for such a change maybe @michaelcullum or someone else needs to validate this?
nunomaduro
approved these changes
Apr 17, 2018
Jean85
approved these changes
May 2, 2018
Member
Jean85
left a comment
There was a problem hiding this comment.
I agree with this change, but I don't think it warrants a new tag.
Contributor
Author
|
Can we merge or close here? Please advise. |
Member
|
Up to the @php-fig/secretaries |
michaelcullum
approved these changes
Dec 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with other PSRs. Not doing the inverse because it doesn't seem useful to me.