Fix registering object handlers on PHP 8.3 #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is great work, thank you so much. I'll work on a release for this and apply the same to 2.x |
|
@rtheunissen Any chance for a release please soon? We want to update to PHP8.3 :) That would be very nice! |
Contributor
|
There is a release on PECL but not on Github yet – I'll get on that. |
Contributor
|
@rtheunissen I'm not seeing any updated release on PECL, only 1.4.0 from early 2021 is listed? Would also love to upgrade to PHP8.3 with our projects! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.3 introduced some changes to how object handlers are registered.
Quote from UPGRADING.INTERNALS:
This fix rougly mimics the change done in bundled PHP extensions in this commit: php/php-src@94ee4f9 while keeping pre-8.3 compatibility.
I've also split the constructor test for PHP <8.1 and >=PHP 8.1 since there's a deprecation emitted by PHP as of PHP 8.1:
The tests should be green an all PHP 7.4-8.3 (didn't test older versions).
closes #77