Skip to content

Adds between(mixed, mixed) method to Decimal class #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtheunissen merged 1 commit into from
Mar 13, 2019
Merged

Adds between(mixed, mixed) method to Decimal class #18

rtheunissen merged 1 commit into from
Mar 13, 2019

Conversation

@fruit
Copy link

@fruit fruit commented Mar 6, 2019

Add one more compare method between to compare in one shot decimal instance to be between to decimals/scalars.

@fruit fruit marked this pull request as ready for review March 6, 2019 18:08
@fruit fruit changed the title Adds ->between(mixed, mixed) method to \Decimal class Adds between(mixed, mixed) method to Decimal class Mar 6, 2019
@rtheunissen
Copy link
Contributor

rtheunissen commented Mar 13, 2019

This looks good to me. I might refactor a bit before the next release but it's all here.

Thanks 👍

@rtheunissen rtheunissen merged commit 7fc3af8 into php-decimal:master Mar 13, 2019
@fruit
Copy link
Author

fruit commented Mar 13, 2019

I might refactor a bit before the next release but it's all here.

I hoped for it. I'm beginner in C/C++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fruit @rtheunissen