Fix random instances of SQL queries having params repeated#505
Merged
barryvdh merged 2 commits intophp-debugbar:masterfrom Oct 31, 2022
Merged
Fix random instances of SQL queries having params repeated#505barryvdh merged 2 commits intophp-debugbar:masterfrom
barryvdh merged 2 commits intophp-debugbar:masterfrom
Conversation
Collaborator
|
Thanks! |
Contributor
Author
|
Any idea when a new release will be pushed out with this change in it @barryvdh? 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my application, I noticed that on seemingly random occurrences, parameters would be repeated when replacing them in the SQL query string: (notice that they display fine in the table under the query, but the first one is inserted in all 3 locations)
This PR fixes this issue.
Looking at open issues here, this seems to be the same issue as #457, but this problem arises for me without using
BETWEENstatements... 🤔I have added a test, and all tests are passing.