Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

Patch download link directly from cron mails #9

Open
alfsb wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patch download link directly from cron mails #9

alfsb wants to merge 3 commits into from

Conversation

@alfsb
Copy link
Member

@alfsb alfsb commented Apr 12, 2016

No description provided.

@kinncj
Copy link

kinncj commented Apr 12, 2016

Nice approach. But I would rather update controller.php that would be able to look for a FileController which deals with files in general... Your diffDownload could be a method and all handled by the controller

Either way, +1!

bjori
bjori reviewed Apr 12, 2016
View reviewed changes
diffRaw.php
exit;
}

print "No patch found. project:$req_proj lang:$req_lang idDB:$req_iddb\n";
Copy link
Member

@bjori bjori Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about this project, but this looks like a gaping xss

@alfsb
Copy link
Member Author

alfsb commented Apr 12, 2016

@kinncj
Ah, it's not nice. I see later there is way to download patchs from editor, but I cannot find how to extract this exact function. So I worked a derivate from /scripts/cron/send_work_to_list.php.

@bjori
This data comes from Online Editor, witch accepts any text. It's expected to not trust/use this output in any automatic interface. Se the above mentioned send_work_to_list.php.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alfsb @kinncj @bjori