Skip to content

Conversation

@PeeHaa
Copy link
Contributor

@PeeHaa PeeHaa commented Jun 1, 2019

I converted 3 pages to use templates:

Next up would be the report-a-bug page, but that needs some more thought as there is a lot going on on that page.

<a href="/stats.php">statistics</a>&nbsp;|&nbsp;
<a href="/random">random bug</a>&nbsp;|&nbsp;
<?php if ($authIsLoggedIn): ?>
<?php if (isset($authIsLoggedIn) && $authIsLoggedIn): ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit; We can use PHP7 syntax on bugs.php.net, so how about:

if ($authIsLoggedIn ?? false):

More concise and avoids repeating the varname.

@sgolemon
Copy link
Member

sgolemon commented Jul 2, 2019

Overall, I'm not a fan of the template file approach of assuming vars in the global scope. It makes tracing the lifetime of a variable much more difficult. -1

@PeeHaa
Copy link
Contributor Author

PeeHaa commented Jul 3, 2019

Overall, I'm not a fan of the template file approach of assuming vars in the global scope.

Vars are not in the global scope though. They are specifically passed into the template. Are you perhaps confusing it with the old way where everything was indeed in the global scope? Or am I missing what you are trying to say?

@PeeHaa
Copy link
Contributor Author

PeeHaa commented Jul 18, 2019

ping @sgolemon

@cmb69
Copy link
Member

cmb69 commented Oct 10, 2019

IMO, this is much cleaner than the old code (and yes, there are no global variables).

<?php $this->start('content') ?>

<?php if ($invalidLogin): ?>
<div style="background: #AB1616; padding: 3px; width: 300px; color: #FFF; margin: 3px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a CSS class used for displaying error messages.

@cmb69
Copy link
Member

cmb69 commented Oct 18, 2021

What's the status here? Maybe we should seriously consider to retire bugsnet in favor of something else?

@peterdd
Copy link
Contributor

peterdd commented Oct 18, 2021

Well, PHP's web-bugs requires a lot of fixes and improvements.
But I think there can be a lot of it done in small steps. It requires some motivated PHP people to regularly review, discuss and merge proposed improvements.

Switching to something else may solve a good portion of current 'not fun' things, but may also add new problems like:

  • Can it handle 80k+ tasks at same/better speed without increasing cost and/or complexity?
  • Adds it dependencies that may hurt in the long run?
  • Who does the migration work and how much 'detail loss' is acceptable?

I saw several tries in the open source world where migrations got stuck and still runs the old ugly but at least somehow working solution.

disclosure 1: I am not part of PHP Group, just a dude who uses PHP.
disclosure 2: I am the current maintainer by of https://github.com/Flyspray/flyspray , also a PHP based bug tracker.

@derickr
Copy link
Member

derickr commented Jul 31, 2024

bugs.php.net is no longer really used, and hence, we're sunsetting it. Due to that, I don't think it makes sense to merge this patch, which also has conflicts.

@cmb69
Copy link
Member

cmb69 commented Jul 31, 2024

Oh, right, further improvements to the bug tracker (especially refactorings) won't make sense anymore.

@cmb69 cmb69 closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants