Closed
Conversation
403c887 to
9ec1340
Compare
Contributor
Author
|
Hooray, it's green on travis! The only failures are tests that also fail in master. |
71e7fa5 to
dc1cce4
Compare
|
👍 , one of the most missing feature in PHP. Great proposal and work ! |
Contributor
Author
|
@mickaelandrieu Thanks! ^^ |
Contributor
Author
|
It's broken on Travis, it won't build and I really don't understand why :( |
121df65 to
f4e1cca
Compare
eee750f to
f1647c5
Compare
sapi/cli/php -r 'function hello(string $world) : string { var_dump(bin2hex($world)); return $world; } echo "foo" . hello(6) . "\n";'
f1647c5 to
d6bea5b
Compare
Contributor
Author
|
|
|
Hello, the RFC is now put as "withdrawn" on php.net, and I was not able to find a reason why, can you give a brief explanation, as that was a very promising feature. |
Contributor
|
@allan-simon their are 2 alternernative PR which implement typehints in a similar fashion |
|
@staabm , is there a separate RFC associated to them or it's still the same RFC but just different implementation ? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For version 0.2 of the RFC.
v0.1's pull request was here: #972