Skip to content

Fix crash when memory limit is exceeded during generator initialization #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arnaud-lb merged 1 commit into from
Oct 22, 2022
Merged

Fix crash when memory limit is exceeded during generator initialization #9802

arnaud-lb merged 1 commit into from
Oct 22, 2022

Conversation

@arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Oct 21, 2022

Fixes #9801

Girgias
Girgias approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't this be backported?

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.0 October 21, 2022 16:43
@arnaud-lb
Copy link
Member Author

arnaud-lb commented Oct 21, 2022

Oh right, I forgot to change the branch when creating the PR

@arnaud-lb
Copy link
Member Author

arnaud-lb commented Oct 22, 2022

Thank you!

@arnaud-lb arnaud-lb marked this pull request as ready for review October 22, 2022 08:40
@arnaud-lb arnaud-lb merged commit 26c7c82 into php:PHP-8.0 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Category: Engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when memory limit is exceeded during generator initialization

2 participants

@arnaud-lb @Girgias