Bug76963 null byte injection #8593
Conversation
cmb69
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you!
(I wasn't aware, or rather forgot, that the NUL byte error message has changed as of PHP 8.0.0; previously, there have been individual checks to avoid "valid path" where it was not about paths; it might make sense to check for leftovers.)
Might make sense to rename the macro with the PATH variant being just a pass through |
ext/date/tests/bug72963.phpt
Outdated
|
|
||
| object(DateTime)#1 (3) { | ||
| ["date"]=> | ||
| string(26) "2016-08-08 13:52:31.000000" |
There was a problem hiding this comment.
Oh, need to do something regarding the time (which may be different); ! or | should do.
iluuu1994
left a comment
There was a problem hiding this comment.
Other than Christoph's comment this LGTM. I also second George's suggestion to add an alias for Z_PARAM_PATH (maybe Z_PARAM_STRING_NO_NUL).
e7abc04 to
209ea3f
Compare
|
I've merged this, and created a ticket assigned to myself to have a better macro name: #8637 |
No description provided.