Fix GH-8140: Wrong first class callable by name optimization#8144
Closed
cmb69 wants to merge 1 commit intophp:PHP-8.1from
Closed
Fix GH-8140: Wrong first class callable by name optimization#8144cmb69 wants to merge 1 commit intophp:PHP-8.1from
cmb69 wants to merge 1 commit intophp:PHP-8.1from
Conversation
When optimizing by name function calls, we must not replace `CALLABLE_CONVERT` opcodes, but have to keep them.
Member
|
Tested locally and looks good to me (although I don't really understand the optimizer). |
TysonAndre
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When optimizing by name function calls, we must not replace
CALLABLE_CONVERTopcodes, but have to keep them.