Fix #76109: Implement fpm_scoreboard_copy #8049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It still needs a bit more testing but tests worked for me so creating PR to see if pipeline is fine. Also I'm considering adding a specific tests for the issue described in https://bugs.php.net/bug.php?id=81275 if possible. |
Member
Author
|
Hmm Does anyone know if this is being handled and when is the pipeline going to be back? |
a2abea8 to
b00c817
Compare
fpm_scoreboard_copy locks the scoreboard while copying the scoreboard and all proc scoreboards. proc scoreboards are locked one by one while copying each struct. The old implementation (inside fpm_handle_status_request) only briefly locked the scoreboard while copying the scorebard. Closes phpGH-7931 Co-authored-by: Jakub Zelenka <bukka@php.net>
b00c817 to
29fe06f
Compare
Member
Member
Yes, it's being worked on. See #8066. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebase of #3188 introducing scoreboard copy with changes to work with the addition of status listen and changes in scoreboard proc layout.